nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1484306822
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -185,14 +195,39 @@ private void initializeCatalogTables() throws
InterruptedException, SQLException
LOG.debug(
"Creating table {} to store iceberg catalog namespace
properties",
JdbcUtil.NAMESPACE_PROPERTIES_TABLE_NAME);
- return
conn.prepareStatement(JdbcUtil.CREATE_NAMESPACE_PROPERTIES_TABLE).execute();
+ return
conn.prepareStatement(JdbcUtil.CREATE_NAMESPACE_PROPERTIES_TABLE_SQL).execute();
});
}
+ private void updateCatalogTables(Connection connection) throws SQLException {
+ DatabaseMetaData dbMeta = connection.getMetaData();
+ ResultSet typeColumn =
+ dbMeta.getColumns(null, null, JdbcUtil.CATALOG_TABLE_VIEW_NAME,
JdbcUtil.TYPE);
+ if (typeColumn.next()) {
+ LOG.debug("{} is already up-to-date", JdbcUtil.CATALOG_TABLE_VIEW_NAME);
Review Comment:
```suggestion
LOG.debug("{} already supports views",
JdbcUtil.CATALOG_TABLE_VIEW_NAME);
```
just a nit, but I feel that `up-to-date` could mean anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
