jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1491386167
########## core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java: ########## @@ -81,6 +87,7 @@ public class JdbcCatalog extends BaseMetastoreCatalog private final Function<Map<String, String>, JdbcClientPool> clientPoolBuilder; private final boolean initializeCatalogTables; private CloseableGroup closeableGroup; + private boolean isNewSqlSchema = true; Review Comment: Does it mean we expose `jdbc.schema-version` to the user (via the `CatalogProperties`) ? My proposal would rather be to use `SchemaVersion` `enum` internally, but expose just a boolean `jdbc.view-support` to the user. I will update the PR this way if it's OK for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
