rahil-c commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1490085636


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1482,6 +1490,34 @@ components:
       explode: false
       example: "vended-credentials,remote-signing"
 
+    page-token:
+      name: pageToken
+      in: query
+      description:
+        An opaque token which allows clients to make use of pagination by 
signaling to the service that they would
+        prefer requests to be paginated based on the number of items specified 
by pageSize.
+        
+        Clients that support pagination initiate the request by sending an 
empty pageToken e.g. GET /tables?pageToken

Review Comment:
   We seem to be aligned after community sync with option 1 and option 2. It 
seems that when calling the `list` namespaces endpoint and adding pageToken in 
the following ways
   ```
   GET /namespaces?pageToken
   or
   GET /namespaces?pageToken=
   ```
   that this does not throw an error when making the request.  In my testing a 
service will interpret the value for pageToken in this case as empty string `""`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to