nastra commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1492051707
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1482,6 +1490,33 @@ components:
explode: false
example: "vended-credentials,remote-signing"
+ page-token:
+ name: pageToken
+ in: query
+ description:
+ An opaque token which allows clients to make use of pagination for a
list API (e.g. ListTables) by signaling to the service
+ that they would prefer response to be paginated.
+
+ Clients will initiate the request by sending an empty pageToken e.g.
GET /tables?pageToken or /tables?pageToken=
+ For servers that support pagination, they will recognize pageToken and
honor the contracts specified above
+ by returning a NextPageToken in response if there are more results
available.
+ For servers that do not support pagination, they will ignore the token
and return all results.
+ required: false
+ allowEmptyValue: true
+ schema:
+ type: string
+
+ page-size:
+ name: pageSize
+ in: query
+ description:
+ For servers that support pagination, this signals an upper bound of
the number of results that client will receive.
+ For servers that do not support pagination, clients may receive
results larger than the indicated pageSize.
+ required: false
+ allowEmptyValue: true
Review Comment:
I don't think `allowEmptyValue` applies for `pageSize`:
https://swagger.io/docs/specification/describing-parameters/
We don't want to allow `GET /tables/?page-size` but rather `GET
/tables/?page-size=123`, so I would just remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
