rdblue commented on code in PR #9620:
URL: https://github.com/apache/iceberg/pull/9620#discussion_r1490230498


##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -479,6 +491,23 @@ public ViewMetadata build() {
           metadataLocation);
     }
 
+    private void removeIntermediateViewVersionIdChanges() {

Review Comment:
   It looks like I was wrong about the way `TableMetadata` works. I don't think 
it is rewriting the set of changes in the build method after all. I think we 
should do that as well to keep it simple and avoid a few problems with doing it 
this way (`removeIf` will not remove duplicates if they set the same version as 
current).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to