rdblue commented on code in PR #9620:
URL: https://github.com/apache/iceberg/pull/9620#discussion_r1477125566
##########
core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java:
##########
@@ -59,6 +60,8 @@ public void commit(ViewMetadata base, ViewMetadata metadata) {
// this is only used for replacing view metadata
Preconditions.checkState(base != null, "Invalid base metadata: null");
+ ViewUtil.verifyReplaceStrictness(base, metadata);
Review Comment:
Could this check be done in `ViewMetadata.Builder` instead? That seems like
a safer place because it is used by all view catalog implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
