amogh-jahagirdar commented on code in PR #9620:
URL: https://github.com/apache/iceberg/pull/9620#discussion_r1477127468
##########
core/src/main/java/org/apache/iceberg/rest/RESTViewOperations.java:
##########
@@ -59,6 +60,8 @@ public void commit(ViewMetadata base, ViewMetadata metadata) {
// this is only used for replacing view metadata
Preconditions.checkState(base != null, "Invalid base metadata: null");
+ ViewUtil.verifyReplaceStrictness(base, metadata);
Review Comment:
What's the rationale for having this in the `ViewUtil` and in a public API?
I think it makes more sense to be `protected` within `ViewOperations` so that
different implementations can just call out to it during the commit. I don't
think it needs to be exposed more than that at least at this point in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
