geruh commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1480721880


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1070,6 +1127,35 @@ paths:
       summary: List all view identifiers underneath a given namespace
       description: Return all view identifiers under this namespace
       operationId: listViews
+      parameters:
+        - name: pageToken
+          in: query
+          description:
+            Allows clients to make use of pagination by signaling to the 
service that they would
+            prefer requests to be paginated to a “reasonable” number of 
results.
+            
+            New Clients always start the request by sending a required empty 
“pageToken” e.g. GET /tables?continuationToken=””
+            Servers supporting pagination would recognize pagination is 
requested due to the presence of the pageToken
+            and honor the contracts specified above by returning a non-empty 
continuation token
+            if there are more results available, or an empty token or missing 
field indicating no more results.
+            Servers that are non-pagination aware will ignore the token and 
return all results as they previously did.
+            
+            Old clients should not be specifying the new parameters
+            For servers that support pagination, they would notice the lack of 
“continuationToken”
+            in the query string and return all results at once (mimicking 
existing behavior).
+            For servers not supporting pagination, this is the current state 
and they would return all values at once.
+          required: false
+          allowEmptyValue: true
+          schema:
+            type: string
+        - name: pageSize
+          in: query
+          description:
+            An upper bound on the number of results to return on the next page.
+          required: false
+          allowEmptyValue: true
+          schema:

Review Comment:
   Should the format be of type uuid?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to