jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1480015041
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -212,6 +212,34 @@ paths:
schema:
type: string
example: "accounting%1Ftax"
+ - name: pageToken
+ in: query
+ description:
+ Allows clients to make use of pagination by signaling to the
service that they would
+ prefer requests to be paginated to a “reasonable” number of
results.
+
+ New Clients always start the request by sending a required empty
“pageToken” e.g. GET /tables?continuationToken=””
+ Servers supporting pagination would recognize pagination is
requested due to the presence of the pageToken
+ and honor the contracts specified above by returning a non-empty
continuation token
+ if there are more results available, or an empty token or missing
field indicating no more results.
+ Servers that are non-pagination aware will ignore the token and
return all results as they previously did.
+
+ Old clients should not be specifying the new parameters
+ For servers that support pagination, they would notice the lack of
“continuationToken”
Review Comment:
yeah this is the point we disagree. I think even when lacking a `pageToken`
query parameter, the service should be able to paginate. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]