jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1480000317
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -212,6 +212,34 @@ paths:
schema:
type: string
example: "accounting%1Ftax"
+ - name: pageToken
+ in: query
+ description:
+ Allows clients to make use of pagination by signaling to the
service that they would
+ prefer requests to be paginated to a “reasonable” number of
results.
+
+ New Clients always start the request by sending a required empty
“pageToken” e.g. GET /tables?continuationToken=””
Review Comment:
1. if the query parameter value is empty, I think it does not contain double
quotes.
2. ~~seems like we want to distinguish the behavior of returning everything
vs returning paginated by passing the initial empty page token. That makes
sense from backwards compatibility perspective, but I think the client should
not need to always start the request with the empty query parameter. If it is
not specified, the service should have the freedom to return all results or a
paginated result, and this still keeps backwards compatibility.~~ see next
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
