jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1479922224
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -80,19 +83,37 @@ public class JdbcCatalog extends BaseMetastoreCatalog
private final Function<Map<String, String>, FileIO> ioBuilder;
private final Function<Map<String, String>, JdbcClientPool>
clientPoolBuilder;
private final boolean initializeCatalogTables;
+ private final boolean updateCatalogTables;
private CloseableGroup closeableGroup;
public JdbcCatalog() {
- this(null, null, true);
+ this(null, null, true, true);
}
+ /**
+ * @deprecated Use {@link JdbcCatalog#JdbcCatalog(Function, Function,
boolean, boolean)} instead;
+ * will be removed in 2.0.0
+ */
+ @Deprecated
public JdbcCatalog(
Function<Map<String, String>, FileIO> ioBuilder,
Function<Map<String, String>, JdbcClientPool> clientPoolBuilder,
boolean initializeCatalogTables) {
this.ioBuilder = ioBuilder;
this.clientPoolBuilder = clientPoolBuilder;
this.initializeCatalogTables = initializeCatalogTables;
+ this.updateCatalogTables = true;
+ }
+
+ public JdbcCatalog(
+ Function<Map<String, String>, FileIO> ioBuilder,
+ Function<Map<String, String>, JdbcClientPool> clientPoolBuilder,
+ boolean initializeCatalogTables,
+ boolean updateCatalogTables) {
+ this.ioBuilder = ioBuilder;
+ this.clientPoolBuilder = clientPoolBuilder;
+ this.initializeCatalogTables = initializeCatalogTables;
+ this.updateCatalogTables = updateCatalogTables;
Review Comment:
@nastra Yes, I think you are right and it was what I did initially. I like
the idea of `jdbc.add-view-support` (`false` by default). I'm updating the PR
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
