ajantha-bhat commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1479508362
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -80,19 +83,37 @@ public class JdbcCatalog extends BaseMetastoreCatalog
private final Function<Map<String, String>, FileIO> ioBuilder;
private final Function<Map<String, String>, JdbcClientPool>
clientPoolBuilder;
private final boolean initializeCatalogTables;
+ private final boolean updateCatalogTables;
private CloseableGroup closeableGroup;
public JdbcCatalog() {
- this(null, null, true);
+ this(null, null, true, true);
}
+ /**
+ * @deprecated Use {@link JdbcCatalog#JdbcCatalog(Function, Function,
boolean, boolean)} instead;
+ * will be removed in 2.0.0
+ */
+ @Deprecated
public JdbcCatalog(
Function<Map<String, String>, FileIO> ioBuilder,
Function<Map<String, String>, JdbcClientPool> clientPoolBuilder,
boolean initializeCatalogTables) {
this.ioBuilder = ioBuilder;
this.clientPoolBuilder = clientPoolBuilder;
this.initializeCatalogTables = initializeCatalogTables;
+ this.updateCatalogTables = true;
+ }
+
+ public JdbcCatalog(
+ Function<Map<String, String>, FileIO> ioBuilder,
+ Function<Map<String, String>, JdbcClientPool> clientPoolBuilder,
+ boolean initializeCatalogTables,
+ boolean updateCatalogTables) {
+ this.ioBuilder = ioBuilder;
+ this.clientPoolBuilder = clientPoolBuilder;
+ this.initializeCatalogTables = initializeCatalogTables;
+ this.updateCatalogTables = updateCatalogTables;
Review Comment:
I strongly believe in "It just works" principle.
Manual intervention with more configurations from the user makes it
complicated and I have seen most of the users not reading the docs. It is not
just spark, we have to think about configurations from pyiceberg and Trino
aswell.
_I am not clearly seeing the problems with "automatic schema update during
initialization and new clients always use the SQL query based on new schema".
Can we please discuss more on this?_
I think we concluded on older clients reading views as table and failing is
ok and we can ask them to upgrade the client if they need views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
