jbonofre commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1478542258
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -81,85 +90,103 @@ final class JdbcUtil {
+ TABLE_NAME
+ ")"
+ ")";
- static final String GET_TABLE_SQL =
+ static final String UPDATE_CATALOG_SQL =
+ "ALTER TABLE " + CATALOG_TABLE_VIEW_NAME + " ADD COLUMN " + TYPE + "
VARCHAR(5)";
+
+ private static final String GET_SQL =
"SELECT * FROM "
- + CATALOG_TABLE_NAME
+ + CATALOG_TABLE_VIEW_NAME
+ " WHERE "
+ CATALOG_NAME
+ " = ? AND "
+ TABLE_NAMESPACE
+ " = ? AND "
+ TABLE_NAME
- + " = ? ";
- static final String LIST_TABLES_SQL =
+ + " = ? AND "
+ + TYPE
+ + " = ?";
+ private static final String GET_TABLE_SQL =
+ GET_SQL
+ + " OR "
+ + TYPE
+ + " IS NULL"; // type is null when the SQL database has been updated
from previous version
+ static final String LIST_SQL =
"SELECT * FROM "
- + CATALOG_TABLE_NAME
+ + CATALOG_TABLE_VIEW_NAME
+ " WHERE "
+ CATALOG_NAME
+ " = ? AND "
+ TABLE_NAMESPACE
+ + " = ? AND "
+ + TYPE
+ " = ?";
- static final String RENAME_TABLE_SQL =
+ static final String LIST_TABLE_SQL = LIST_SQL + " OR " + TYPE + " IS NULL";
+ static final String RENAME_SQL =
"UPDATE "
- + CATALOG_TABLE_NAME
+ + CATALOG_TABLE_VIEW_NAME
+ " SET "
+ TABLE_NAMESPACE
- + " = ? , "
+ + " = ?, "
+ TABLE_NAME
- + " = ? "
+ + " = ?"
+ " WHERE "
+ CATALOG_NAME
+ " = ? AND "
+ TABLE_NAMESPACE
+ " = ? AND "
+ TABLE_NAME
- + " = ? ";
- static final String DROP_TABLE_SQL =
+ + " = ? AND "
+ + TYPE
+ + " = ?";
+ static final String RENAME_TABLE_SQL = RENAME_SQL + " OR " + TYPE + " IS
NULL";
Review Comment:
Yeah, it would be probably cleaner. I will do that.
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -81,85 +90,103 @@ final class JdbcUtil {
+ TABLE_NAME
+ ")"
+ ")";
- static final String GET_TABLE_SQL =
+ static final String UPDATE_CATALOG_SQL =
+ "ALTER TABLE " + CATALOG_TABLE_VIEW_NAME + " ADD COLUMN " + TYPE + "
VARCHAR(5)";
+
+ private static final String GET_SQL =
"SELECT * FROM "
- + CATALOG_TABLE_NAME
+ + CATALOG_TABLE_VIEW_NAME
+ " WHERE "
+ CATALOG_NAME
+ " = ? AND "
+ TABLE_NAMESPACE
+ " = ? AND "
+ TABLE_NAME
- + " = ? ";
- static final String LIST_TABLES_SQL =
+ + " = ? AND "
+ + TYPE
+ + " = ?";
+ private static final String GET_TABLE_SQL =
+ GET_SQL
Review Comment:
Yeah, it would be probably cleaner. I will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
