nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1481631049
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcUtil.java:
##########
@@ -18,14 +18,116 @@
*/
package org.apache.iceberg.jdbc;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import java.sql.ResultSet;
import java.util.Map;
import java.util.Properties;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;
+import org.sqlite.SQLiteDataSource;
public class TestJdbcUtil {
+ @Test
+ public void testUpdate() throws Exception {
+ SQLiteDataSource dataSource = new SQLiteDataSource();
+ dataSource.setUrl("jdbc:sqlite:file::memory:?icebergDB");
Review Comment:
In addition to just checking whether the schema has been updated correctly,
we need to also test catalog operations (listTables() / listViews() / ...).
We should also have a test where we have the old schema with some data and
then start the catalog with default settings (`jdbc.add-view-support` is set to
`false`) to make sure `catalog.listTables()` (and others) work as expected and
return correct results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
