jbonofre commented on code in PR #9487: URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475829107
########## core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java: ########## @@ -71,7 +68,7 @@ public void doRefresh() { Map<String, String> table; try { - table = getTable(); + table = JdbcUtil.tableOrView(true, connections, catalogName, tableIdentifier); Review Comment: It's check only table here (as the first argument to `tableOrView()` method is `true`. I agree that it doesn't seem obvious at first glance, so I will do specific methods for view and table to avoid confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org