nicor88 commented on PR #288: URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1903491270
Regarding moto - I totally agree with you @mgmarino, it helps to test only API specs, and as the main catalog source of true is glue (also for athena), mocking athena via moto is not enough. Therefore, to support both of your comments, I believe that integration testing for Athena/glue/s3 are the only way to fully test and assure that all works as expected - this is the same path that we took also in https://github.com/dbt-athena/dbt-athena, where we use moto for unit tests, but then we have end to end tests were we test full athena/glue behaviour (for iceberg tables included). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
