mgmarino commented on PR #288: URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1903463726
Thanks, @HonahX, @nicor88. Yes, I verified the correct behavior as well (creation of table, schema change, etc.) before pushing, but I am happy to formalize this in an integration test and will do so. :-) Re moto: for me, the only *real* value of moto is in ensuring that we call the aws API correctly. I think we can't rely on it to reproduce the internal functionality of AWS services, and certainly not an Athena query, so I would simply go the direction of doing this an integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
