HonahX commented on PR #288:
URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1902879704
@mgmarino @nicor88 Thanks for your input.
> Did you try to evolve the table schema and see if the changes are properly
updated in glue and usable in Athena?
I did a simple test
```python
table = catalog.load_table(table_identifier)
table.update_schema().add_column("y", StringType()).commit()
to_append2 = pa.Table.from_pandas(
pd.DataFrame([dict(x="hello!", y="world!")])
)
table.append(to_append2)
```
and the Athena could successfully run `SELECT * FROM` on the updated table:
both the original column and new column show up in the result.
For testing, I think it would be nice to add one or two Athena-related
checks to both unit tests and integration tests. However , I think
[`moto`](https://docs.getmoto.org/en/latest/docs/services/athena.html) does not
run Athena query by default, which cannot help us verify the Athena behavior in
unit test. So, may be adding such check in integration tests is good enough.
(Please correct me if I am wrong about moto athena)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
