mgmarino commented on PR #288: URL: https://github.com/apache/iceberg-python/pull/288#issuecomment-1902635769
> Also, if possible, could you please also add some tests in [integration_test_glue.py](https://github.com/apache/iceberg-python/blob/3085c404c99ba8c5c8856f21a6c8d63a12ca0113/tests/catalog/integration_test_glue.py)? This file contains similar tests in `test.glue.py` but it interacts with the real Glue service. To run the test, you will need AWS credentials and specify a bucket via env variable `AWS_TEST_BUCKET`: > > https://github.com/apache/iceberg-python/blob/3085c404c99ba8c5c8856f21a6c8d63a12ca0113/tests/conftest.py#L1701-L1706 > > Thanks! Hi @HonahX thanks for the review! I’ll have a look soon, but I just wanted to get a feeling about what we should test in the integration test that’s not covered here. IMHO, for this update I think a full test that looks like: - make a table with pyiceberg - verify subsequent query with Athena would make sense, but would possibly require a little more than just access to a bucket. (I’m just not sure about if there are any limitations on the CI AWS account.) i will anyways go in that direction, let me know if you had something else in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
