pvary commented on code in PR #9346: URL: https://github.com/apache/iceberg/pull/9346#discussion_r1442664555
########## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceSql.java: ########## @@ -39,4 +62,76 @@ public void before() throws IOException { .getConfiguration() .set(TableConfigOptions.TABLE_DYNAMIC_TABLE_OPTIONS_ENABLED, true); } + + private Record generateRecord(Instant t1) { + Record record = GenericRecord.create(SCHEMA_TS); + record.setField("t1", t1.atZone(ZoneId.systemDefault()).toLocalDateTime()); + record.setField("t2", t1.getEpochSecond()); Review Comment: What I do not like in this test, that if we make a mistake and switch `t1` with `t2` in somewhere in the production code, or in the test then we will not see a difference in the test results. That is why I originally suggested, that the different columns have different values to make sure that the `watermark-column` value is propagated correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org