rodmeneses commented on code in PR #9346: URL: https://github.com/apache/iceberg/pull/9346#discussion_r1434279736
########## flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java: ########## @@ -94,7 +94,7 @@ private FlinkConfigOptions() {} public static final ConfigOption<SplitAssignerType> TABLE_EXEC_SPLIT_ASSIGNER_TYPE = ConfigOptions.key("table.exec.iceberg.split-assigner-type") .enumType(SplitAssignerType.class) - .defaultValue(SplitAssignerType.SIMPLE) + .defaultValue(null) Review Comment: > If users have not opt-ed into the new feature, I would expect their SQL queries to still work. Can you add tests to ensure that? Hi! I didn't get your suggestion about the unit test. Would you please rephrase? Thanks @mas-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org