stevenzwu commented on code in PR #9346:
URL: https://github.com/apache/iceberg/pull/9346#discussion_r1445375116
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -272,6 +279,14 @@ public int maxAllowedPlanningFailures() {
return maxAllowedPlanningFailures;
}
+ public String watermarkColumn() {
+ return watermarkColumn;
+ }
+
+ public TimeUnit watermarkTimeUnit() {
Review Comment:
method name should be `watermarkColumnTimeUnit`
##########
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java:
##########
@@ -190,4 +191,22 @@ public int maxAllowedPlanningFailures() {
.defaultValue(FlinkReadOptions.MAX_ALLOWED_PLANNING_FAILURES_OPTION.defaultValue())
.parse();
}
+
+ public String watermarkColumn() {
+ return confParser
+ .stringConf()
+ .option(FlinkReadOptions.WATERMARK_COLUMN)
+ .flinkConfig(FlinkReadOptions.WATERMARK_COLUMN_OPTION)
+ .defaultValue(FlinkReadOptions.WATERMARK_COLUMN_OPTION.defaultValue())
+ .parseOptional();
+ }
+
+ public TimeUnit watermarkTimeUnit() {
Review Comment:
method name should be `watermarkColumnTimeUnit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
