nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432834544
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestReadProjection.java:
##########
@@ -49,7 +50,7 @@ public abstract class TestReadProjection {
protected abstract Record writeAndRead(
String desc, Schema writeSchema, Schema readSchema, Record record)
throws IOException;
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir protected Path temp;
Review Comment:
because you're changing this file it seems you'd also have to update
`TestSparkReadProjection`, otherwise CI won't pass.
Alternatively you could reintroduce
```
import org.junit.Assert;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
```
but leave the AssertJ conversions in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
