Fokko commented on code in PR #122:
URL: https://github.com/apache/iceberg-rust/pull/122#discussion_r1431074561
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -79,6 +79,22 @@ impl Manifest {
Ok(Manifest { metadata, entries })
}
+
+ /// Upgrade the format version of this manifest.
+ pub fn upgrade_version(&mut self, format_version: FormatVersion) ->
Result<(), Error> {
Review Comment:
> Let's remove this interface and only fix the init-default.
This will make thing easier, such as setting the sequence-number when the
field isn't present (in the case of V1 metadata).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
