ZENOTME commented on code in PR #122:
URL: https://github.com/apache/iceberg-rust/pull/122#discussion_r1430919505
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -820,15 +834,24 @@ pub(super) mod _serde {
.zip(partition_types)
.map(|(v, field)| v.try_into(&field.field_type))
.collect::<Result<Vec<_>, _>>()
- })
- .transpose()?
- .unwrap_or_default())
+ } else {
+ Err(Error::new(
+ crate::ErrorKind::DataInvalid,
Review Comment:
Have added context of entry path and spec id. We don't have the manifest
list file path for now (we pass [u8] to parse directly), I think it need to set
in the high level API.
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -820,15 +834,24 @@ pub(super) mod _serde {
.zip(partition_types)
.map(|(v, field)| v.try_into(&field.field_type))
.collect::<Result<Vec<_>, _>>()
- })
- .transpose()?
- .unwrap_or_default())
+ } else {
+ Err(Error::new(
+ crate::ErrorKind::DataInvalid,
Review Comment:
Have added context of entry path and spec id. We don't have the manifest
list file path for now (we pass [u8] to parse directly), I think it need to set
in the higher level API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
