liurenjie1024 commented on code in PR #122:
URL: https://github.com/apache/iceberg-rust/pull/122#discussion_r1430828303
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -820,15 +834,24 @@ pub(super) mod _serde {
.zip(partition_types)
.map(|(v, field)| v.try_into(&field.field_type))
.collect::<Result<Vec<_>, _>>()
- })
- .transpose()?
- .unwrap_or_default())
+ } else {
+ Err(Error::new(
+ crate::ErrorKind::DataInvalid,
Review Comment:
I'm expecting a better error message with more context, for example, the
manifest list file path, the entry path, spec id.
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -79,6 +79,22 @@ impl Manifest {
Ok(Manifest { metadata, entries })
}
+
+ /// Upgrade the format version of this manifest.
+ pub fn upgrade_version(&mut self, format_version: FormatVersion) ->
Result<(), Error> {
Review Comment:
+1 for this concern. Version upgrade is part of transaction api, it involves
full rewrite of all things like snapshot, and should not do it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
