liurenjie1024 commented on code in PR #122:
URL: https://github.com/apache/iceberg-rust/pull/122#discussion_r1430880402
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -79,6 +79,22 @@ impl Manifest {
Ok(Manifest { metadata, entries })
}
+
+ /// Upgrade the format version of this manifest.
+ pub fn upgrade_version(&mut self, format_version: FormatVersion) ->
Result<(), Error> {
Review Comment:
I checked that comment, but I don't think we need to introduce this api for
now. The manifest format upgradation is part of table format upgradation, and
we need to think about it in the overall design, rather exposing this single
api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
