pvary commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1414267995
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##########
@@ -49,37 +51,28 @@
import org.apache.iceberg.types.Types;
import org.apache.iceberg.util.DateTimeUtil;
import org.assertj.core.api.Assertions;
-import org.junit.Assert;
-import org.junit.ClassRule;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-
-@RunWith(Parameterized.class)
-public abstract class TestFlinkScan {
-
- @ClassRule
- public static final MiniClusterWithClientResource MINI_CLUSTER_RESOURCE =
- MiniClusterResource.createWithClassloaderCheckDisabled();
-
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new
TemporaryFolder();
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.io.TempDir;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
- @Rule
- public final HadoopCatalogResource catalogResource =
- new HadoopCatalogResource(TEMPORARY_FOLDER, TestFixtures.DATABASE,
TestFixtures.TABLE);
+public abstract class TestFlinkScan {
+ @RegisterExtension
+ public static MiniClusterExtension miniClusterResource =
+ MiniFlinkClusterExtension.createWithClassloaderCheckDisabled();
- // parametrized variables
- protected final FileFormat fileFormat;
+ @TempDir Path temporaryDirectory;
- @Parameterized.Parameters(name = "format={0}")
- public static Object[] parameters() {
- return new Object[] {"avro", "parquet", "orc"};
- }
+ @RegisterExtension
+ public final HadoopCatResource catalogResource =
+ new HadoopCatResource(temporaryDirectory, TestFixtures.DATABASE,
TestFixtures.TABLE);
- TestFlinkScan(String fileFormat) {
- this.fileFormat = FileFormat.fromString(fileFormat);
+ public static Stream<Arguments> parameters() {
+ return Stream.of(
+ Arguments.of(FileFormat.fromString("avro")),
Review Comment:
Also please join the discussion on #9161 to decide a general way to
implement parametrized tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
