nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1415409451
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -309,8 +307,8 @@ public static void assertEquals(Schema schema,
List<GenericData.Record> records,
public static void assertEquals(Schema schema, GenericData.Record record,
Row row) {
List<Types.NestedField> fields = schema.asStruct().fields();
- Assert.assertEquals(fields.size(), record.getSchema().getFields().size());
- Assert.assertEquals(fields.size(), row.getArity());
+ assertThat(fields.size()).isEqualTo(record.getSchema().getFields().size());
+ assertThat(fields.size()).isEqualTo(row.getArity());
Review Comment:
```suggestion
assertThat(fields).hasSize(row.getArity());
```
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -338,81 +336,73 @@ private static void assertAvroEquals(
return;
}
- Assert.assertTrue(
- "expected and actual should be both null or not null", expected !=
null && actual != null);
+ assertThat(expected != null && actual != null)
+ .as("expected and actual should be both null or not null")
+ .isTrue();
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
