nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1415401117
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -159,9 +159,9 @@ public static void assertRowData(
return;
}
- Assert.assertTrue(
- "expected Record and actual RowData should be both null or not null",
- expectedRecord != null && actualRowData != null);
+ assertThat(expectedRecord != null && actualRowData != null)
Review Comment:
this should be `assertThat(expectedRecord).isNotNull()` and then
`assertThat(actualRowData).isNotNull()`.
We want to avoid using isTrue/isFalse as much as possible, because it's more
difficult to debug when the assertion fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
