liurenjie1024 commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1413303245
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Hi, @mobley-trent Yes, we are planning to delegate conversion between
literal values and json values to ser/de module, just like what we did with
avro. You're right complete removing `From<&values::Literal>` will not work
before that. I think we can hold on this pr brefore that the json conversion
was finished.
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Hi, @mobley-trent Yes, we are planning to delegate conversion between
literal values and json values to ser/de module, just like what we did with
avro. You're right complete removing `From<&values::Literal>` will not work
before that. I think we can hold on this pr before that the json conversion was
finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
