liurenjie1024 commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1403271641
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
Sorry, I mean we should remove the total implementation of `From<&Literal>
for JsonValue`. Since we have decided to remove type info for `Struct`, this
method signature is incorrect. The conversion from/to json should delegate to
ser/de module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
