mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1405212670
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
},
Literal::Struct(s) => {
Review Comment:
`serde_json` doesn't seem to have a method to extract the JsonValue from the
Literal. This was only possible through `From<&Literal> for JsonValue`
This line raises a compiler error when I removed `From<&Literal> for
JsonValue`
```rust
fn check_json_serde(json: &str, expected_literal: Literal, expected_type:
&Type) {
...
let expected_json_value: JsonValue = (&expected_literal).into(); //
error raised here
```
Error:
```rust
^^^^ the trait `From<&values::Literal>` is not implemented for
`serde_json::Value`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
