fqaiser94 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1396541554
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -768,7 +769,7 @@ pub struct SnapshotLog {
/// Id of the snapshot.
pub snapshot_id: i64,
/// Last updated timestamp
- pub timestamp_ms: i64,
+ pub timestamp_ms: TimestampMillis,
Review Comment:
Reverted this change and added a method named `timestamp`.
##########
crates/iceberg/src/spec/timestamp_millis.rs:
##########
Review Comment:
We don't need the newtype anymore since I don't need to change the fields of
any `Struct` to `DateTime<UTC>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
