liurenjie1024 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1393639699
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -153,7 +155,7 @@ pub(super) mod _serde {
#[serde(skip_serializing_if = "Option::is_none")]
pub parent_snapshot_id: Option<i64>,
pub sequence_number: i64,
- pub timestamp_ms: i64,
+ pub timestamp_ms: TimestampMillis,
Review Comment:
This is not public api, I don't think we should change this.
##########
crates/iceberg/src/spec/timestamp_millis.rs:
##########
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::fmt::Formatter;
+
+use chrono::{DateTime, NaiveDateTime, TimeZone, Utc};
+use serde::de;
+use serde::de::Visitor;
+use serde::{Deserialize, Deserializer, Serialize, Serializer};
+
+#[derive(Debug, PartialEq, Eq, Clone, Copy)]
+/// A NewType wrapping DateTime<Utc> with millisecond precision
Review Comment:
Move comments above `derive` part?
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -768,7 +769,7 @@ pub struct SnapshotLog {
/// Id of the snapshot.
pub snapshot_id: i64,
/// Last updated timestamp
- pub timestamp_ms: i64,
+ pub timestamp_ms: TimestampMillis,
Review Comment:
I think we should provide a method to return `TimestampMillis` rather
changing the field.
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -167,7 +169,7 @@ pub(super) mod _serde {
pub snapshot_id: i64,
#[serde(skip_serializing_if = "Option::is_none")]
pub parent_snapshot_id: Option<i64>,
- pub timestamp_ms: i64,
+ pub timestamp_ms: TimestampMillis,
Review Comment:
Ditto.
##########
crates/iceberg/src/spec/timestamp_millis.rs:
##########
Review Comment:
Do we really need this newtype? I think following would be enough:
```
pub type TimestampMillis = DateTime<Utc>;
```
And `chrono` already provided [this conversion
method](https://docs.rs/chrono/latest/chrono/offset/trait.TimeZone.html#method.timestamp_millis_opt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
