Xuanwo commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1390182259
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, used for garbage
/// collection and table inspection
- timestamp_ms: i64,
+ timestamp_ms: Timestamp,
Review Comment:
We used to have a discussion about this.
https://github.com/apache/iceberg-rust/pull/20/files#diff-0ab4b2d8c9bcfbb43cb0a06b6ef3015098edf660cbeebb5f196a55eba0326b83
The general idea is to **use long/int representation**.
We just convert them to chrono types as public API.
---
*By the way, I still believe that directly storing a `DateTime<Utc>` is a
good idea. However, I don't want to reopen a discussion on a topic we've
already reached consensus on.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
