liurenjie1024 commented on code in PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#discussion_r1390573721
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -72,7 +73,7 @@ pub struct Snapshot {
sequence_number: i64,
/// A timestamp when the snapshot was created, used for garbage
/// collection and table inspection
- timestamp_ms: i64,
+ timestamp_ms: Timestamp,
Review Comment:
> We used to have a discussion about this.
>
> #20 (comment)
>
> The general idea is to use long/int representation.
>
> We just convert them to chrono types as public API.
+1. We have reached consensus, so we should not change the internal field
representation without a strong reason. What I meant was also to return chrono
types as public api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
