jacobmarble commented on code in PR #8971:
URL: https://github.com/apache/iceberg/pull/8971#discussion_r1382165939
##########
api/src/main/java/org/apache/iceberg/transforms/Days.java:
##########
@@ -55,14 +56,14 @@ public boolean satisfiesOrderOf(Transform<?, ?> other) {
}
if (other instanceof Timestamps) {
- return Timestamps.DAY.satisfiesOrderOf(other);
+ return ((Timestamps) other).getResultTypeUnit() == ChronoUnit.DAYS
Review Comment:
Fixed in 3b87435b31eac16b86b4118e79cb54fabf367b64
##########
api/src/main/java/org/apache/iceberg/transforms/Hours.java:
##########
@@ -57,15 +58,16 @@ public boolean satisfiesOrderOf(Transform<?, ?> other) {
}
if (other instanceof Timestamps) {
- return other == Timestamps.HOUR;
- } else if (other instanceof Hours
- || other instanceof Days
- || other instanceof Months
- || other instanceof Years) {
- return true;
+ return ((Timestamps) other).getResultTypeUnit() == ChronoUnit.HOURS
Review Comment:
Fixed in 3b87435b31eac16b86b4118e79cb54fabf367b64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
