Fokko commented on code in PR #8971:
URL: https://github.com/apache/iceberg/pull/8971#discussion_r1381247301
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -205,27 +208,56 @@ public String toString() {
}
public static class TimestampType extends PrimitiveType {
- private static final TimestampType INSTANCE_WITH_ZONE = new
TimestampType(true);
- private static final TimestampType INSTANCE_WITHOUT_ZONE = new
TimestampType(false);
+
+ private static final TimestampType INSTANCE_MICROS_WITH_ZONE =
+ new TimestampType(true, ChronoUnit.MICROS);
+ private static final TimestampType INSTANCE_MICROS_WITHOUT_ZONE =
+ new TimestampType(false, ChronoUnit.MICROS);
+ private static final TimestampType INSTANCE_NANOS_WITH_ZONE =
+ new TimestampType(true, ChronoUnit.NANOS);
+ private static final TimestampType INSTANCE_NANOS_WITHOUT_ZONE =
+ new TimestampType(false, ChronoUnit.NANOS);
public static TimestampType withZone() {
Review Comment:
Should we mark these as deprecated? And suggest using `microsWithZone()`
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
