Fokko commented on code in PR #8971:
URL: https://github.com/apache/iceberg/pull/8971#discussion_r1381166396
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -589,17 +603,17 @@ private static String sanitizeNumber(Number value, String
type) {
return "(" + numDigits + "-digit-" + type + ")";
}
- private static String sanitizeString(CharSequence value, long now, int
today) {
+ private static String sanitizeString(CharSequence value, long nowMillis, int
today) {
try {
if (DATE.matcher(value).matches()) {
Literal<Integer> date = Literal.of(value).to(Types.DateType.get());
return sanitizeDate(date.value(), today);
} else if (TIMESTAMP.matcher(value).matches()) {
- Literal<Long> ts =
Literal.of(value).to(Types.TimestampType.withoutZone());
- return sanitizeTimestamp(ts.value(), now);
+ Literal<Long> ts =
Literal.of(value).to(Types.TimestampType.nanosWithoutZone());
Review Comment:
Do we always want to interpret it as NANOs? Depending on the datatype that's
being used this might restrict the range of dates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
