Fokko commented on code in PR #8971: URL: https://github.com/apache/iceberg/pull/8971#discussion_r1381238654
########## api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java: ########## @@ -121,17 +121,13 @@ static <R> R visit(Schema schema, PartitionField field, PartitionSpecVisitor<R> } else if (transform instanceof Truncate) { int width = ((Truncate<?>) transform).width(); return visitor.truncate(field.fieldId(), sourceName, field.sourceId(), width); - } else if (transform == Dates.YEAR - || transform == Timestamps.YEAR - || transform instanceof Years) { + } else if ("year".equalsIgnoreCase(transform.toString())) { Review Comment: These changes seem unrelated to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org