nastra commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375070758
##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/LakeFormationTestBase.java:
##########
@@ -417,7 +432,20 @@ private static void registerResource(String s3Location) {
.build());
// when a resource is registered, LF will update SLR with necessary
permissions which has a
// propagation delay
- waitForIamConsistency();
+ Awaitility.await()
+ .pollDelay(Duration.ofSeconds(1))
+ .atMost(Duration.ofSeconds(10))
+ .ignoreExceptions()
+ .untilAsserted(
+ () ->
+ Assertions.assertThat(
+ lakeformation
+ .describeResource(
+
DescribeResourceRequest.builder().resourceArn(arn).build())
+ .resourceInfo()
+ .roleArn()
+ .equalsIgnoreCase(lfRegisterPathRoleArn))
Review Comment:
this should do `.isEqualToIgnoringCase(lfRegisterPathRoleArn))` rather than
`isTrue()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
