amogh-jahagirdar commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1371705732
##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/LakeFormationTestBase.java:
##########
@@ -417,7 +431,16 @@ private static void registerResource(String s3Location) {
.build());
// when a resource is registered, LF will update SLR with necessary
permissions which has a
// propagation delay
- waitForIamConsistency();
+ Awaitility.await()
+ .pollDelay(Duration.ofSeconds(1))
+ .atMost(Duration.ofSeconds(10))
+ .until(
+ () ->
+ lakeformation
Review Comment:
I believe the same thing @nastra pointed out
https://github.com/apache/iceberg/pull/8804/files#r1371698377 applies here as
well.
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -435,13 +437,11 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exception {
for (int numCommittedFiles = 0;
numCommittedFiles < numberOfCommitedFilesPerThread;
numCommittedFiles++) {
- while (barrier.get() < numCommittedFiles * threadsCount) {
- try {
- Thread.sleep(10);
- } catch (InterruptedException e) {
- throw new RuntimeException(e);
- }
- }
+ final int currentFilesCount = numCommittedFiles;
+ Awaitility.await()
+ .pollInterval(Duration.ofMillis(10))
+ .pollInSameThread()
Review Comment:
@nk1506 I think the question was more around what's the issue if
`pollInSameThread` is not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
