nastra commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375786953


##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/SparkSQLExecutionHelper.java:
##########
@@ -53,7 +53,7 @@ public static String lastExecutedMetricValue(SparkSession 
spark, String metricNa
     // Refresh metricValues, they will remain null until the execution is 
complete and metrics are
     // aggregated
     Awaitility.await()
-        .atMost(Duration.ofMillis(500))
+        .atMost(Duration.ofSeconds(10))

Review Comment:
   this shouldn't be 10 seconds, but maybe rather 1-3 seconds. The old version 
of the code was relying on something around 500 millis



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to