nk1506 commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1372614898
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -435,13 +437,11 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exception {
for (int numCommittedFiles = 0;
numCommittedFiles < numberOfCommitedFilesPerThread;
numCommittedFiles++) {
- while (barrier.get() < numCommittedFiles * threadsCount) {
- try {
- Thread.sleep(10);
- } catch (InterruptedException e) {
- throw new RuntimeException(e);
- }
- }
+ final int currentFilesCount = numCommittedFiles;
+ Awaitility.await()
+ .pollInterval(Duration.ofMillis(10))
+ .pollInSameThread()
Review Comment:
@amogh-jahagirdar , My intent was to use the same test thread here. Since we
have multiple runnable tasks here. I don't think it was flaky because of not
using `pollInSameThread()` .
Please share your thoughts about adding `pollInSameThread()` here is a good
idea or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
