pvary commented on code in PR #8803: URL: https://github.com/apache/iceberg/pull/8803#discussion_r1369761574
########## core/src/main/java/org/apache/iceberg/ManifestGroup.java: ########## @@ -417,6 +429,10 @@ boolean shouldKeepStats() { return !dropStats; } + Set<Integer> statsToKeep() { Review Comment: Fixed everywhere (I hope, will check). ########## core/src/main/java/org/apache/iceberg/TableScanContext.java: ########## @@ -125,6 +132,16 @@ TableScanContext shouldReturnColumnStats(boolean returnColumnStats) { .build(); } + TableScanContext columnsToIncludeStats(Set<Integer> columnStatsToInclude) { + Preconditions.checkState( + returnColumnStats(), + "Cannot select column stats to include when column stats are not returned"); Review Comment: Changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org