stevenzwu commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1367939105
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java:
##########
@@ -152,6 +155,16 @@ public boolean includeColumnStats() {
.parse();
}
+ public Set<Integer> columnStatsToKeep() {
+ return split(
Review Comment:
Regarding schema evolution (like field rename), users have to adjust the
name reference. this is also applicable to filter expressions or column
projections. Users typically reference fields by name. I still treat field id
as internal identifier to ensure safe schema evolution. it is not friendly to
ask users to provide filed ids for filter, projection, etc.
In another thought, I am also not sure we need to expose this to users
directly. The only usage of column stats is the watermark alignment. we will
need to expose `enableWatermarkAlignment(String watermarkField)` anyway. there
is probably no need to expose this directly, at least not yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
