pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1369761206
##########
core/src/main/java/org/apache/iceberg/GenericDataFile.java:
##########
@@ -66,23 +68,30 @@ class GenericDataFile extends BaseFile<DataFile> implements
DataFile {
* Copy constructor.
*
* @param toCopy a generic data file to copy.
- * @param fullCopy whether to copy all fields or to drop column-level stats
+ * @param fullCopy whether to copy all fields or to drop column-level stats.
+ * @param statsToKeep a set of column ids to keep stats. If empty or
<code>null</code> then every
+ * column stat is kept.
*/
- private GenericDataFile(GenericDataFile toCopy, boolean fullCopy) {
- super(toCopy, fullCopy);
+ private GenericDataFile(GenericDataFile toCopy, boolean fullCopy,
Set<Integer> statsToKeep) {
Review Comment:
Fixed everywhere (I hope, will check).
##########
core/src/main/java/org/apache/iceberg/GenericDeleteFile.java:
##########
@@ -67,23 +69,30 @@ class GenericDeleteFile extends BaseFile<DeleteFile>
implements DeleteFile {
* Copy constructor.
*
* @param toCopy a generic data file to copy.
- * @param fullCopy whether to copy all fields or to drop column-level stats
+ * @param fullCopy whether to copy all fields or to drop column-level stats.
+ * @param statsToKeep a set of column ids to keep stats. If empty or
<code>null</code> then every
+ * column stat is kept.
*/
- private GenericDeleteFile(GenericDeleteFile toCopy, boolean fullCopy) {
- super(toCopy, fullCopy);
+ private GenericDeleteFile(GenericDeleteFile toCopy, boolean fullCopy,
Set<Integer> statsToKeep) {
Review Comment:
Fixed everywhere (I hope, will check).
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -381,19 +390,22 @@ static class TaskContext {
private final DeleteFileIndex deletes;
private final ResidualEvaluator residuals;
private final boolean dropStats;
+ private final Set<Integer> statsToKeep;
private final ScanMetrics scanMetrics;
TaskContext(
PartitionSpec spec,
DeleteFileIndex deletes,
ResidualEvaluator residuals,
boolean dropStats,
+ Set<Integer> statsToKeep,
Review Comment:
Fixed everywhere (I hope, will check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
