pvary commented on code in PR #8803: URL: https://github.com/apache/iceberg/pull/8803#discussion_r1369762281
##########
docs/flink-configuration.md:
##########
@@ -130,6 +130,7 @@ env.getConfig()
| streaming | connector.iceberg.streaming
| N/A | false | Sets
whether the current task runs in streaming or batch mode.
|
| monitor-interval | connector.iceberg.monitor-interval
| N/A | 60s | Monitor
interval to discover splits from new snapshots. Applicable only for streaming
read.
|
| include-column-stats | connector.iceberg.include-column-stats
| N/A | false | Create a
new scan from this that loads the column stats with each data file. Column
stats include: value count, null value count, lower bounds, and upper bounds.
|
+| column-stats-to-keep | connector.iceberg.column-stats-to-keep
| N/A | empty | Create a
new scan from this that loads the column stats with each data file for the
specified column ids. Column stats include: value count, null value count,
lower bounds, and upper bounds.
|
Review Comment:
Removed as per another comment
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java:
##########
@@ -152,6 +155,16 @@ public boolean includeColumnStats() {
.parse();
}
+ public Set<Integer> columnStatsToKeep() {
Review Comment:
Fixed everywhere (I hope, will check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
