pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1367842806


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java:
##########
@@ -152,6 +155,16 @@ public boolean includeColumnStats() {
         .parse();
   }
 
+  public Set<Integer> columnStatsToKeep() {
+    return split(

Review Comment:
   Using column names opens an entirely new can of worms. How do we handle 
schema evolution? If we accept, that we do not solve this issue, then we can 
use the `Schema.findField` for easy conversion, but then the users could not 
solve the issue themselves if they used schema evolution 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to